Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another missing bump (impl-codec) #863

Merged
merged 5 commits into from
Sep 12, 2024
Merged

another missing bump (impl-codec) #863

merged 5 commits into from
Sep 12, 2024

Conversation

ordian
Copy link
Member

@ordian ordian commented Sep 12, 2024

cc #862 @pgherveou

I'll publish impl-codec 0.7 and primitive-types 0.13.1 and yank 0.13.0 (same for ethereum-types and ethbloom).

Hopefully, that's the only missing bump.

@ordian
Copy link
Member Author

ordian commented Sep 12, 2024

Published and yanked previous versions

@ordian ordian merged commit 7c701c6 into master Sep 12, 2024
6 checks passed
@ordian ordian deleted the ao-another-missing-bump branch September 12, 2024 11:18
@pgherveou
Copy link
Contributor

Published and yanked previous versions

Nice thanks will try to build my PR with that.
Any thoughts on moving this repo to polkadot-sdk so that we can have the crates versions managed by the existing process?

@ordian
Copy link
Member Author

ordian commented Sep 12, 2024

Nice thanks will try to build my PR with that.

Let me know if you encounter an issue again :)

Any thoughts on moving this repo to polkadot-sdk so that we can have the crates versions managed by the existing process?

I don't think the existing process would have caught this issue. The problem is that macros generate code which they don't even depend on explicitly (e.g. impl-codec doesn't depend on uint but generates the code that uses it).

On the general topic of moving parity-common into polkadot-sdk: the original purpose for separation was that we'd share the code between (now obsolete) parity-ethereum and substrate.
Now it is more about sharing the code between polkadot-sdk and frontier. Although I'm not up-to-date with which dependencies are actually shared.
I think some crates in parity-common will be deprecated and removed (like kvdb-rocksdb with the switch to paritydb). What's left, might be replaced by more modern alternatives (e.g. #673)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants