Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIX/IBM i support #133

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

NattyNarwhal
Copy link

Addresses #124.

Notes:

  • I have not tested this very well. This was made to support nx, but unfortunately trying to override a specific version of watcher for nx's tangled web of dependencies is a pain.
  • The reason why there are openat shims is because IBM i has a defective *at implementation that only supports AT_FDCWD. The shims were provided to me from IBM and are OK for use here. They could be broken out to a separate file though.
  • Only the brute force strategy will work. Watchman doesn't support AIX, but I left it as an option in case it does or there's an alternative implementation.

No backends get built otherwise. Only uses brute force watcher for
now; another strategy may be possible, but isn't implemented.
probably should be broken into sep file
AIX doesn't have d_type
['OS=="aix" or OS=="os400"', {
"sources": [
"src/watchman/BSER.cc",
"src/watchman/WatchmanBackend.cc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the slow response on this PR.

One problem is that I don't think watchman is supported on AIX or OS400. There is also no inotify support as far as I can tell (I don't have access to a system to test this). Without either of those, this module isn't very useful (can't actually watch files). Do you know if these OSes have another file watching mechanism?

I'm also somewhat concerned about adding these as I have no way of testing or providing precompiled builds for these platforms. Do you have access to such a system to test with?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late response.

Watchman isn't supported, but I didn't disable it, because Watchman is an external tool - I was thinking that it might support it or an alternative with a compatible interface might. It might be a good idea to disable it though.

It's using the "legacy" backend which is brute force; AFAIK there is no watching API, but I might be wrong. I can ask my contacts at IBM.

I understand the concerns about not being able to test things. I do have access to a system for testing. FWIW not having a binary build is OK; the user I'm doing this for is already used to having the dev toolchain to build native parts already.

(FWIW, the motivation to upstream this was things depending on watcher being extremely common in some ecosystems. Finding and patching every dependency to pull a patched copy was too onerous.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a ping out here - would like to know if the above is still blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants