Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: size prop can't order corretly. #838

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GiveMe-A-Name
Copy link

@GiveMe-A-Name GiveMe-A-Name commented Oct 17, 2024

Example

.foo { 
   height: auto; 
   height: calc(100vh - var(--header-height, 0rem)); 
}

After lightningcss minify, css code would like this

.foo { 
   height: calc(100vh - var(--header-height, 0rem)); 
   height: auto; 
}

But it's not expect.
we can maintain the last prop, then delete the repeat prop. Like bellow:

.foo { 
   height: calc(100vh - var(--header-height, 0rem)); 
}

fix: #805

@sbyps
Copy link

sbyps commented Oct 19, 2024

anyone can review this PR? @devongovett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]lighting css will shuffle css properties order
2 participants