Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update relative color parsing to latest spec #465

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

devongovett
Copy link
Member

The CSS spec was updated in w3c/csswg-drafts#7876 to treat many channel values as only numbers rather than percentages or numbers for the purposes of calculations in relative colors. This is a breaking change since it no longer allows syntax like calc(l + 10%), you need to do calc(l + 10) or calc(l * 1.1) depending on what you want to do. In addition, the range of each channel is different, for example l is 0-100 in lch, but 0-1 in oklch.

Unfortunately, we did not ship relative color syntax under a draft flag, so if we release this change in a minor version it might be an unexpected breaking change. Haven't decided what to do here yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant