-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt at fixing aiohttp timeouts #3
Open
andersy005
wants to merge
1
commit into
main
Choose a base branch
from
specify-aiohttp-timeouts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martindurant, i could be wrong but it appears that
pangeo-forge-recipes
doesn't know how to serialize thislet me know if any hints/workarounds come to mind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andersy005, this looks like a similar problem to the recent
process_input
andprocess_chunk
serialization issue.Two possible workarounds:
aiohttp.ClientSession
read_timeout
andconn_timeout
parameters are deprecated in favour oftimeout
used in this PR commit, maybe they can be used as a short-term workaround as they accept floats (rather thanaiohttp.ClientTimeout
used fortimeout
), and should be serializable.FilePattern
has its ownsha256()
implementation, and althoughfsspec_open_kwargs
is currently included, perhaps this could be excluded (similar to the patternformat_function
and combine dims currently excluded), or particularkwargs
(e.g. anyaiohttp
instances) could be excluded fromfsspec_open_kwargs
prior to serialization. I guess a timeout value is something that isn't necessary for a recipe hash?https://github.com/pangeo-forge/pangeo-forge-recipes/blob/3441d94a290d296b8f62638df15bb60993e86b1d/pangeo_forge_recipes/patterns.py#L299
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andersy005, it looks like @yuvipanda is having a similar
aiohttp
hash problem in the daymet staged recipe as he's usingaiohttp.BasicAuth
infsspec_open_kwargs["client_kwargs"]
. More details here.