-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Solution for issue #60044 #60058
base: main
Are you sure you want to change the base?
Conversation
@ZKaoChi , See the error message for the failed test:
(Keep lines below 89 characters.) |
@5j9 I see. Thanks a lot!!! |
pandas/_libs/tslibs/timedeltas.pyx
Outdated
Denote the unit of the input, if input is an integer. | ||
If input is an integer, denote the unit of the input. | ||
If input is a float, denote the unit of integer parts. | ||
(If unit = None, ignore decimal parts. Otherwise proportionally convert them.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that: pd.Timedelta(0.123456789, 'microseconds')
returns 0 days 00:00:00.000000123
.
So it's not the unit
that determines the rounding, but the lowest timedelta resolution which is currently 1ns.
I'd suggest:
"If value is a float, the decimal parts of the value that require a precision higher than a nanosecond will be ignored."
(This could be added to value
's description instead.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your accommodating and suggestion! I will make some changes to the content and my commit title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another suggestion: I'd use a more descriptive commit title. Something that gives more information about the issue at hand rather than just referring to issue number.
value
parameter ofpandas.Timedelta
can also accept float #60044