BUG: Fix copy semantics in __array__
#60046
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the semantics of
__array__
. While rejectingcopy=False
is OK even if unnecessary,copy=True
should never have been ignored and is dangerous.Closes gh-57739, gh-59932
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.I have to figure out the tests. I think a test in form of:
will work nicely. But, right now I am not sure if there is a convenient pattern/parametrization to steal to cover all of the
__array__
implementations here.