Improve error mesage verbosity #59900
Open
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhshadrach - could you take a look at this? thanks |
rhshadrach
requested changes
Oct 21, 2024
pandas/core/strings/accessor.py
Outdated
| @@ -255,7 +255,9 @@ def _validate(data): | |||
| inferred_dtype = lib.infer_dtype(values, skipna=True) | |||
|
|
|||
| if inferred_dtype not in allowed_types: | |||
| raise AttributeError("Can only use .str accessor with string values!") | |||
| raise AttributeError( | |||
| f"Can only use .str accessor with string values!, not {inferred_dtype}" | |||
There was a problem hiding this comment.
Can you remove the !, I believe it is not grammatically correct.
rhshadrach
requested changes
Oct 22, 2024
|
I think this looks good, but the CI has many unrelated failures. I'd like to get those resolved before merging PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Continued stale PR: #59649