PERF: Return RangeIndex from RangeIndex.reindex when possible #57647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Performance
mroeschke
requested review from
rhshadrach,
WillAyd and
datapythonista
as code owners
|
I think something went wrong with git here, feels like this have unrelated changes, right? |
| tm.assert_index_equal(result, expected, exact=True) | ||
|
|
||
| expected_indexer = np.array([1, -1, -1], dtype=np.intp) | ||
| tm.assert_numpy_array_equal(result_indexer, expected_indexer) |
There was a problem hiding this comment.
Would it make sense to add a test case when RangeIndex can't be returned? Like, if we call ri.reindex([1, 3, 9]) my expectation is that it should still return Index, which I guess it does, but I wonder whether your changes can make it raise instead. I think it'd be good to have a test for that, and I couldn't find one already in the test suite.
There was a problem hiding this comment.
Sure added a test in the same file where RangeIndex.reindex will return an Index
datapythonista
approved these changes
Mar 5, 2024
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…-dev#57647) * PERF: Return RangeIndex from RangeIndex.reindex when possible * Add whatsnew number * Only if index * add name * Skip for type self, undo test * Use intp * merge * Add test for Index return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #57441