Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code was already good and fully correct but in my opinion this makes … #57514

Closed
wants to merge 1 commit into from
Closed

Code was already good and fully correct but in my opinion this makes … #57514

wants to merge 1 commit into from

Conversation

GrzegorzSzczepanek
Copy link

@GrzegorzSzczepanek GrzegorzSzczepanek commented Feb 19, 2024 •
edited
Loading

…code a bit more readable.

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

phofl
phofl requested changes Feb 19, 2024
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not equivalent

Please refrain from PRs like this in the future

@phofl phofl closed this Feb 19, 2024
@GrzegorzSzczepanek GrzegorzSzczepanek deleted the minor-readability-change branch February 19, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrzegorzSzczepanek @phofl