Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix PR02 errors in docstring for pandas.Series.str.wrap #57321

Merged
merged 8 commits into from
Feb 13, 2024

Conversation

jordan-d-murphy
Copy link
Contributor

All PR02 Errors resolved in the following cases:

  1. scripts/validate_docstrings.py --format=actions --errors=PR02 pandas.Series.str.wrap

@jordan-d-murphy
Copy link
Contributor Author

jordan-d-murphy commented Feb 9, 2024

I've updated the signature of wrap but now some of my tests are failing, I'll need to fix this before you take another look @mroeschke

@jordan-d-murphy
Copy link
Contributor Author

@mroeschke ready for your review when you get a chance

@simonjayhawkins simonjayhawkins added Docs Code Style Code style, linting, code_checks labels Feb 10, 2024
@jordan-d-murphy
Copy link
Contributor Author

pre-commit.ci autofix

@mroeschke mroeschke added this to the 3.0 milestone Feb 13, 2024
@mroeschke mroeschke merged commit 373fb91 into pandas-dev:main Feb 13, 2024
47 checks passed
@mroeschke
Copy link
Member

Thanks @jordan-d-murphy

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…dev#57321)

* DOC: fix PR02 errors in docstring for pandas.Series.str.wrap

* change signature of wrap to include kwargs as explicit parameters

* fixing call to _str_wrap()

* Added all textwrap.TextWrapper parameters

* update width argument to remain positional by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants