Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Improve MultiIndex label rename checks, docs and tests #56936

Closed

Conversation

TabLand
Copy link

@TabLand TabLand commented Jan 18, 2024

@TabLand TabLand force-pushed the correct-multi-index-rename-checks branch from 15ae2c0 to fcf2d3d Compare January 18, 2024 00:34
@TabLand TabLand marked this pull request as draft January 18, 2024 10:12
@TabLand
Copy link
Author

TabLand commented Jan 18, 2024

Actually, I think I need to write an additional test for when errors="raise" and a rename is successful against a MultiIndex. That fails without this patch because of the inconsistency between the check and transform logic

@TabLand TabLand force-pushed the correct-multi-index-rename-checks branch 3 times, most recently from d1ff9b0 to 20d0df8 Compare January 18, 2024 23:42
@TabLand TabLand marked this pull request as ready for review January 18, 2024 23:43
@TabLand
Copy link
Author

TabLand commented Jan 19, 2024

Hi @phofl , @mroeschke,
Would you be able to help review this PR?

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Mar 21, 2024
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Mar 26, 2024
@TabLand
Copy link
Author

TabLand commented Mar 29, 2024

Hi @mroeschke,
I've updated my branch to resolve merge conflicts. The new tests are still passing on my machine.
Could you kindly reopen this PR?

@mroeschke
Copy link
Member

It appears I cannot reopen this PR as there was a force push. Would be happy to have a new PR with your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Pandas column rename function now working for multilevel columns
3 participants