Adding new variables for docstring #48831
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added and passed if fixing a bug or adding a new featureAll code checks passed.Added type annotations to new arguments/methods/functions.Added an entry in the latestdoc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.I am creating this PR to get comments on whether this solution is correct or not.
Solution - The Timestamp class is inheriting from datetime. Values of
month
,day
,hour
,minute
,second
andmicrosecond
variables are used of that of datetime class. To add the docstring, I am proposing to create one new variable for each. I have added a variable forhour
as an example.I don't know whether it will affect performance and memory usage. Do we have some existing mechanism to measure it and then compare with old results?