Add init_app() method to DebugPanel base class
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Example:: | ||
|
|
||
| class UMLDiagramPanel(DebugPanel): |
There was a problem hiding this comment.
Probably :)
What specifically are you referring to?
There was a problem hiding this comment.
There's stuff about UMLDiagramPanel in there that I don't think is correct?
Oh, that's an example. Never mind.
jeffwidman
changed the title
init_app()-method to DebugPanel base classinit_app() method to DebugPanel base class
|
I know it's been a long time, but do you still have any interest in this? |
Adds a method `DebugPanel.init_app()` that gets called from `DebugToolbar.init_app()`. This allows DebugPanels to register their own routes, and do setup work that should go across requests (as opposed to per-request setup) and needs access to the Flask `app`-object.
malthejorgensen
force-pushed
the
add-DebugPanel.init_app
branch
from
aaf0ef1
to
5bf5e09
Compare
|
@macnewbold Thank you for the flag. I've rebased on latest |
macnewbold
approved these changes
Dec 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method
DebugPanel.init_app()that gets called fromDebugToolbar.init_app().This allows
DebugPanelsto register their own routes, and do setup work that should go across requests (as opposed to per-request setup) and needs access to the Flaskapp-object.