Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use of before_first_request #218

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Remove the use of before_first_request #218

merged 1 commit into from
Nov 17, 2023

Conversation

greyli
Copy link
Member

@greyli greyli commented Nov 16, 2023

This decorator has been removed in Flask 3.0.

macnewbold
macnewbold approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@macnewbold macnewbold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, and make sense. Is this compatible with all of our supported versions of Flask, or does this mean Flask 2.x will no longer work?

@jeffwidman
Copy link
Member

Great question.

FWIW, if it's painful to retain backwards compatibility, don't be afraid to also drop support for Flask < 3.x. Most of those users will be fine with the older releases of Flask-DebugToolbar, and the ones who are currently broken are on newer Flask. Plus given the limited maintenance time this project receives, better to fix forward and start from a cleanish slate if needed. Whatever seems better to you two.

@greyli
Copy link
Member Author

greyli commented Nov 17, 2023

This change won't break the Flask 2.x and Flask 1.x compatibility.

@greyli greyli merged commit 2b8bf9c into pallets-eco:master Nov 17, 2023
0 of 10 checks passed
@greyli
Copy link
Member Author

greyli commented Nov 17, 2023

Merged. I updated the test database URL to the in-memory SQLite database so that it will work on Windows.

@greyli greyli deleted the fix-flask-api branch November 17, 2023 14:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macnewbold macnewbold macnewbold approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greyli @jeffwidman @macnewbold