-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tox and GitHub actions settings #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about using single quotes around the name for all 3 Python 3.12 names? This would match the others.
@@ -7,8 +7,6 @@ on: | |||
- 'docs/**' | |||
- '*.rst' | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I double checked this in the docs at: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
When you omit any value here it defaults to '**'
which matches all branch and tag names.
It's OK since these names don't contain dots or whitespaces. Similar to the settings in Flask. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me.
Let's ship this, added a trivial inline code comment for clarity, hope you don't mind. If you do feel strongly about that, let me know so that in the future I know to wait for you. |
ubuntu-20.04
for Python 3.6 since it's been removed inubuntu-latest
setup-python
steppip install
commands