Don't use POST method for sql_select/explain #116
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've installed the debug toolbar on my application and it works well. Thanks.
But because I was using
Flask_WTF
withCSRF
protection, I was receiving400 Bad Request
errors each time I was clicking on theSELECT
orEXPLAIN
link in theSQLAlchemy
panel.Of course, I found a proper way to handle this with better configuration of the
CSRF
protection in my app.However I don't think that we need to use the
POST
method for thesql_select
orsql_explain
routes.This pull request makes sure that we only accept
GET
and that the browser uses the correct method to call the service (using JQuery load method).