Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only install public headers on CMake install #25

Merged
merged 1 commit into from
Oct 5, 2024
Merged

fix: Only install public headers on CMake install #25

merged 1 commit into from
Oct 5, 2024

Conversation

paleolimbot
Copy link
Owner

Another approach to #24, which discovered that we were installing the vendored headers into /usr/include/vendored/!

@jorisvandenbossche jorisvandenbossche mentioned this pull request Oct 5, 2024
Closed
@paleolimbot paleolimbot merged commit 66ee95d into master Oct 5, 2024
4 checks passed
@paleolimbot paleolimbot mentioned this pull request Oct 7, 2024
Merged
paleolimbot added a commit that referenced this pull request Oct 7, 2024
@paleolimbot
fix: Fix install location and Arrow ABI include (#27)
829a0fe 
After #25 the resulting install was `include/s2geography/s2geography`
and was missing `s2geography.h`!

This PR also fixes some consistency issues around `#pragma once` that
have prevented downstream projects from using the Arrow interface (e.g.,
#23).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paleolimbot