Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use blocking interface in annotation processor example #1977

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Use blocking interface in annotation processor example #1977

merged 1 commit into from
Jul 21, 2023

Conversation

pkoenig10
Copy link
Member

We've seen consumers use async interfaces when it's not necessary simply because that's what appears to be suggested by the README. We'd prefer consumers to use sync interfaces where possible because they are easier to reason about.

carterkozak
carterkozak approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pkoenig10!

@bulldozer-bot bulldozer-bot bot merged commit 576c412 into develop Jul 21, 2023
1 check passed
@bulldozer-bot bulldozer-bot bot deleted the pkoenig10-patch-1 branch July 21, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

Assignees
No one assigned
Labels
merge when ready no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkoenig10 @carterkozak