#19 fix appended site path beeing ignored #20
Conversation
|
Nice catch, we did basically drop the site |
|
Are you able to adjust the CLI tests to haven an error which your change fixes? I tried myself with a custom site base URL but that didn't work reliably ... |
|
A little readme in the project how to setup the test environment would be helpful. I started the docker compose environment and run into a php version mismatch. |
|
Indeed, added now: e23379a |
| @@ -29,7 +29,9 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface | |||
| { | |||
| $action = new OpcacheAction(OpcacheAction::RESET); | |||
|
|
|||
| if (strtolower($request->getMethod()) !== $action->getRequestMethod() || $request->getUri()->getPath() !== $action->getUriPath()) { | |||
| $resetPathDetected = substr_compare($request->getUri()->getPath(), $action->getUriPath(), -(strlen($action->getUriPath())), strlen($action->getUriPath())) === 0; | |||
There was a problem hiding this comment.
This is impossible to read and understand. ;-) Maybe use str_(starts|ends)_with()?
Also currently it sounds like we stop processing if "our" path is detected which is contrary to what actually happens.
There was a problem hiding this comment.
Sorry for pushing this wip-code to the PR.
Well str_ends_with() makes it incompatible with PHP 7.4 ...
For making it readable I introduces a speaking variable. But I'm happy about a better solution :-)
There was a problem hiding this comment.
I wouldn't mind requiring symfony/polyfill-php80 for this.
|
Sadly I was still not able to execute the tests locally . Build is crashing because phpstan is complaining. Running "docker compose run --rm app composer test" crashes with an connection error. Sorry I'm not too deep into docker compose. BTW. on my Linux host the command has to be "docker compose" (without the minus) |
|
You can use both the standalone (Python) as well as embedded (Go) version of Docker Compose. Which actually works fine everywhere, see e.g. the CI here. 🤔 |
No description provided.