Add PromptOAuth component #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the UI of a tool to continue to be shown, but for a prompt to grant access to be overlaid on-top. This was added as a new component as it's behaviour is quite different to the existing OAuth component in that it doesn't have any child components.
| </Modal.Header> | ||
| <Modal.Body> | ||
| <View as='div'> | ||
| Please grant permission to load this content. This is a one-time (two-step) authorisation. |
There was a problem hiding this comment.
This sentence I had to read twice , since for me brackets imply non-necessary further detail.
There was a problem hiding this comment.
I know, I don't like the message at all.
| // what content is waiting on the OAuth grant. For example in the Module Titles | ||
| // there may be other content in the page that doesn't require the granting of | ||
| // permission | ||
| background: 'rgba( 200, 200, 200, 0.5 )' |
There was a problem hiding this comment.
css or we do stuff inline too these days if it's one-off/small?
There was a problem hiding this comment.
Sorry, what are you suggesting here? We need to override the theme variables as documented: https://instructure.design/#using-theme-overrides
| // This is to grey out the background behind the modal more so that it's clear | ||
| // what content is waiting on the OAuth grant. For example in the Module Titles | ||
| // there may be other content in the page that doesn't require the granting of | ||
| // permission |
There was a problem hiding this comment.
Nice explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the UI of a tool to continue to be shown, but for a prompt to grant access to be overlaid on-top.
This was added as a new component as it's behaviour is quite different to the existing OAuth component in that it doesn't have any child components.