this adds the remove user call from the accounts api, and a wrapper o… #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject to get the user
buckett
reviewed
Feb 26, 2024
| @@ -99,4 +102,15 @@ public Boolean deleteAccount(String parentAccountId, String accountId) throws IO | |||
| Optional<Delete> responseParsed = responseParser.parseToObject(Delete.class, response); | |||
| return responseParsed.map(r -> r.getDelete()).orElse(false); | |||
| } | |||
|
|
|||
| public User deleteUser(Integer userId) throws IOException { | |||
There was a problem hiding this comment.
Rather than passing in a Integer here, I'd pass in a String as that way the same API can be used with both user ID numbers and prefixed identifiers (eg SIS IDs).
|
|
||
| public User deleteUser(Integer userId) throws IOException { | ||
| Map<String, List<String>> postParams = new HashMap<>(); | ||
| String deleteUrl = buildCanvasUrl("accounts/" + CanvasConstants.ACCOUNT_ID + "/users/" + userId, Collections.emptyMap()); |
There was a problem hiding this comment.
Although i our instance our root account is 1 it's not always the case and passing in the account ID is the more portable solution. Again it should be a String so we can use SIS IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bject to get the user