fix: do no hit LDAP if no exposed attribute is configured #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvillafanez
force-pushed
the
fix_no_exposed_attrs
branch
from
6d18e92
to
720eeb6
Compare
jvillafanez
force-pushed
the
fix_no_exposed_attrs
branch
from
720eeb6
to
620adee
Compare
IljaN
approved these changes
Oct 15, 2024
|
good to merge now |
|
Please add a changelog |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are no exposed attributes configured in the ldap's wizard, we shouldn't hit the LDAP server trying to get the exposed attributes.
Link: https://github.com/owncloud/enterprise/issues/6856