Changes for implementing the new sync mech from core #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jvillafanez
force-pushed
the
new_sync_mech
branch
from
92675b4
to
3413c85
Compare
|
I guess the phpstan error will be fixed when the PR in core is merged, but I'm not sure if we should rise the minimum version. I don't think there will be problems if this code is run in 10.13 or earlier because the offending code won't be loaded, but maybe we should be more explicit and write a warning in the |
jvillafanez
force-pushed
the
new_sync_mech
branch
from
5b74592
to
d60c4af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new user sync mechanism developed in core (owncloud/core#41016)
New feature is added conditionally, based on the presence of the new syncManager in core. This will keep compatibility with previous versions, so there is no need to rise the OC minimum supported version.