Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update templates to use new protobuf api #3

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Apr 25, 2020

  1. update templates to use new protobuf api

    Google introduced a new protobuf API: https://blog.golang.org/protobuf-apiv2 causing the current release of staticckeck to barf on several related packages: dominikh/go-tools#732 ... fixed in dominikh/go-tools@7e758a3
    
    Currently, protoc-gen-microweb uses `github.com/golang/protobuf/jsonpb` which is still reported:
    ```
    make staticcheck
    go run honnef.co/go/tools/cmd/staticcheck -tags '' github.com/owncloud/ocis-hello/cmd/ocis-hello github.com/owncloud/ocis-hello/pkg/assets github.com/owncloud/ocis-hello/pkg/command github.com/owncloud/ocis-hello/pkg/config github.com/owncloud/ocis-hello/pkg/flagset github.com/owncloud/ocis-hello/pkg/metrics github.com/owncloud/ocis-hello/pkg/proto/v0 github.com/owncloud/ocis-hello/pkg/server/debug github.com/owncloud/ocis-hello/pkg/server/grpc github.com/owncloud/ocis-hello/pkg/server/http github.com/owncloud/ocis-hello/pkg/service/v0 github.com/owncloud/ocis-hello/pkg/version
    pkg/proto/v0/hello.pb.micro.go:8:2: package github.com/golang/protobuf/proto is deprecated: Use the "google.golang.org/protobuf/proto" package instead.  (SA1019)
    pkg/proto/v0/hello.pb.web.go:14:2: package github.com/golang/protobuf/jsonpb is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead.  (SA1019)
    exit status 1
    make: *** [Makefile:73: staticcheck] Fehler 1
    ```
    
    This PR should update the dependency.
    butonic authored Apr 25, 2020
    Configuration menu
    Copy the full SHA
    7f82a49 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Configuration menu
    Copy the full SHA
    b109246 View commit details
    Browse the repository at this point in the history