Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log which fed-share is scanned #41311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IljaN
Copy link
Member

@IljaN IljaN commented Aug 21, 2024

ScanExternalShares Job should log which share it is attempting to scan so the admin can see in the logs which share is faulty and returns a 401.

Copy link

update-docs bot commented Aug 21, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Aug 21, 2024

@DeepDiver1975
Copy link
Member

ScanExternalShares Job should log which share it is attempting to scan so the admin can see in the logs which share is faulty and returns a 401.

But it would be better to add this information when the 401 is logged to have the direct correlation, same log level and not spam the log in successful cases.

any bug report we can ref here? thx

Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add necessary information to the error log and not spam the log in all cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants