[Do not merge] Unique constraint for duplicate child shares

.drone.star

@@ -1651,7 +1651,7 @@ def acceptance(ctx):
  "federatedServerVersions": [""],
  "browsers": ["chrome"],
  "phpVersions": [DEFAULT_PHP_VERSION],
- "databases": ["mariadb:10.2"],
+ "databases": ["postgres:9.2"],
  "federatedPhpVersion": DEFAULT_PHP_VERSION,
  "federatedServerNeeded": False,
  "federatedDb": "",

core/Migrations/Version20240507143125.php

@@ -0,0 +1,27 @@
+<?php
+namespace OC\Migrations;
+
+use Doctrine\DBAL\Platforms\MySqlPlatform;
+use Doctrine\DBAL\Platforms\PostgreSqlPlatform;
+use Doctrine\DBAL\Platforms\SqlitePlatform;
+use OCP\IDBConnection;
+use OCP\Migration\ISqlMigration;
+
+class Version20240507143125 implements ISqlMigration {
+ public function sql(IDBConnection $connection) {
+ $dbPlatform = $connection->getDatabasePlatform();
+ if ($dbPlatform instanceof PostgreSqlPlatform || $dbPlatform instanceof SqlitePlatform) {
+ return ["CREATE UNIQUE INDEX child_share_unique ON oc_share (share_with, parent) 
+ WHERE parent IS NOT NULL AND share_type = 2"];
+ }
+
+ if ($dbPlatform instanceof MySqlPlatform) {
+ // This should be preceise enough as mysql ignores nulls in unique indexes
+ return [
+ "CREATE UNIQUE INDEX child_share_unique ON oc_share (item_source, share_with, share_type, parent);"
+ ];
+ }
+
+ return [];
+ }
+}

lib/private/Share20/DefaultShareProvider.php

@@ -559,7 +559,7 @@ public function getShareById($id, $recipientId = null) {
  // and, depending on the database, the query may throw an exception
  // with a message like "invalid input syntax for type integer"
  // So throw ShareNotFound now.
- throw new ShareNotFound();
+ throw new ShareNotFound("invalid id: $id");
  }
  $qb = $this->dbConn->getQueryBuilder();