Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tag to Powah's Dry Ice #147

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Adds tag to Powah's Dry Ice #147

merged 3 commits into from
Feb 12, 2021

Conversation

OneLemonyBoi
Copy link
Contributor

@OneLemonyBoi OneLemonyBoi commented Feb 11, 2021

It makes mod compat easier, and will help achieve this pull request to Immersive Engineering: BluSunrize/ImmersiveEngineering#4646

@owmii
Copy link
Owner

owmii commented Feb 12, 2021

Thanks!!

Copy link
Contributor

@BlueAgent BlueAgent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be editing src/generated/* directly. Add to TagsProvider and then running datagen is probably better.

BlueAgent added a commit to BlueAgent/Powah that referenced this pull request Feb 13, 2021
Also switched to using new datagen constructors.
BlueAgent added a commit to BlueAgent/Powah that referenced this pull request Feb 13, 2021
Also switched to using new datagen constructors.
@BlueAgent BlueAgent mentioned this pull request Feb 13, 2021
BlueAgent added a commit to BlueAgent/Powah that referenced this pull request Feb 13, 2021
Also switched to using new datagen constructors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants