Supply mysql8.4.0 by default #1071
Conversation
| @@ -45,6 +45,7 @@ services: | |||
| --character-set-server=utf8mb3 | |||
| --collation-server=utf8mb3_general_ci | |||
| --binlog-expire-logs-seconds=259200 | |||
| --mysql-native-password=ON | |||
There was a problem hiding this comment.
- Reference for this change?
- This would be needed in k8s as well.
There was a problem hiding this comment.
The plugin mysql-native-password is disable by default in mysql 8.4.0 that makes us unable to authenticate with user having native password, such as the root user in our case. See here for more context.
There was a problem hiding this comment.
This option seems to be deprecated and during my testing, I found that removing this did not effect anything in my tutor installation. Can you confirm once again if this is required?
There was a problem hiding this comment.
Yes, I have tested it again. We are able to authenticate with root user without the plugin.
There was a problem hiding this comment.
I've tested these changes on the latest redwood release, and it seems to be working just fine for me. I've even tested my own changes in #1065 with this PR and it seems to be working.
However, I think the mysql-native-password option should be removed as it seemed to be working fine for me even after removing it.
DawoudSheraz
changed the title
|
Changes have been tested on dev environment as well as k8s. The |
|
@ormsbee did you see this? Would you agree that we upgrade MySQL to 8.4.0 in Redwood, given that 8.1.0 is EOL? |
|
@regisb: I had not seen it, thank you for tagging me. I agree that it makes sense to go to 8.4 in Redwood. |
|
FTR I expect we'll stick with 8.4.0 for as long as possible (2029). |
|
@regisb Thanks for the discussions on this. Once you give a 👍🏽 , I will merge this. |
|
Looking good :) please make sure to squash all commits during rebase. |
fixes #1051
MySQL 8.4.0 LTS has been released. It is set as default in the settings.
Following things has been tested (on dev and k8s) and working perfectly:
Ability to create user and admin user
Create a course and its visibility on LMS
Ability to login to MySQL with native root user.