-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable more plugins for Sumac #63
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
.github/workflows/deploy.yml
Outdated
@@ -113,10 +112,10 @@ jobs: | |||
$SSH "#! /bin/bash -e | |||
$TUTOR config save --append 'OPENEDX_EXTRA_PIP_REQUIREMENTS=edx-event-routing-backends>=7.2.0,<8.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aspects also tries to install another version of edx-event-routing-backends
here.
We should probably clarify which version we want to install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, good catch. This was added back in 2022 #13 and has seen some frequent version upgrades. For the sake of consistency, we can make it the same as aspects i.e. edx-event-routing-backends>=9.3.0,<9.4".
@ziafazal Hi, do you know if there can be any issues if we update edx-event-routing-backends here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DawoudSheraz We should remove event-routing-backends from OPENEDX_EXTRA_PIP_REQUIREMENTS
now instead we should rely on aspects to test if event-routing-backends is working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was it added in the first place? I don't think we should rely on aspects for testing event-routing-backends considering we only enabled aspects for Redwood and Sumac and event-routing-backends has been in this script for quite a long time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use to test event-routing-backends by adding it OPENEDX_EXTRA_PIP_REQUIREMENTS
when Aspects was not built but now it should be tested with Aspects since Aspects is the only consumer of event-routing-backends in open edx ecosystem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the installation of edx-event-routing-backends from the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Description