initial support for accessors (tc39 stage 3 proposal) #14451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/renamer.zig
Outdated
| @@ -725,7 +729,10 @@ pub const NumberRenamer = struct { | |||
|
|
|||
| /// Caller must use an arena allocator | |||
| pub fn findUnusedName(this: *NumberScope, allocator: std.mem.Allocator, temp_allocator: std.mem.Allocator, input_name: []const u8) UnusedName { | |||
| var name = bun.MutableString.ensureValidIdentifier(input_name, temp_allocator) catch unreachable; | |||
| var name = if (input_name[0] == '#') | |||
| allocator.dupe(u8, input_name) catch unreachable | |||
There was a problem hiding this comment.
what happens if there's a non-ascii character in a private name?
|
|
||
| if (is_private_prop) { | ||
| old_property_name = property.key.?.data.e_string.string(p.allocator) catch bun.outOfMemory(); | ||
| new_property_name = std.fmt.allocPrint(p.allocator, "#{s}", .{old_property_name}) catch bun.outOfMemory(); |
There was a problem hiding this comment.
why isn't this a private property ref?
| @@ -21808,14 +21808,14 @@ fn NewParser_( | |||
| continue; | |||
| } | |||
| if (@as(Expr.Tag, property.key.?.data) != .e_string and @as(Expr.Tag, property.key.?.data) != .e_private_identifier) { | |||
| p.log.addError(p.source, property.key.?.loc, "'accessor' property key must be a string or private identifier") catch unreachable; | |||
| out_properties.push(p.allocator, property.*) catch unreachable; | |||
| p.log.addError(p.source, property.key.?.loc, "'accessor' property key must be a string or private identifier") catch bun.outOfMemory(); | |||
There was a problem hiding this comment.
these can all be try right?
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this PR brings initial support for accessors defined by the tc39 stage 3 proposal for decorators. https://github.com/tc39/proposal-decorators
TODO:
How did you verify your code works?