Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6829 updates to the dmca policy #4953

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Nil-Cipher
Copy link

@Nil-Cipher Nil-Cipher commented Nov 5, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6829

Purpose

Update the DMCA page with the new html.

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

Go to https://archiveofourown.org/dmca and check for the new content.

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

I have a Jira account but no editing access.

References

Are there other relevant issues/pull requests/mailing list discussions?

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

@sarken
Copy link
Collaborator

sarken commented Nov 5, 2024

Hi, Nil-Cipher!

Thank you for working on this! Someone will be along to review shortly after you move it out of Draft status. In the meantime, I've updated the Jira issue status to In Review, so no one will mistakenly create a duplicate pull request.

If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! You can just reply here with the account name and we'll set up the permissions for you. (It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME).")

Thanks again for contributing! If you have any questions, you can contact us at [email protected].

@Nil-Cipher
Copy link
Author

Nil-Cipher commented Nov 5, 2024

@sarken Do you have an auto-linter? I ran erblint and it caught some things, but I don't want to go and manually fix them.

Also my jira account is https://otwarchive.atlassian.net/jira/people/5e76ab1fbea00d0c4118b73b

@Nil-Cipher Nil-Cipher marked this pull request as ready for review November 5, 2024 08:06
@Nil-Cipher
Copy link
Author

Found an ERB linter in vscode. This is my first PR, so I didn't touch the i18 stuff. It seemed complicated with the large paragraphs, every <p> would need a new variable name and I'm not that creative.
The test other_a is failing because I'm changing the html of the DMCA page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants