Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-5951 Added CSS for Fixing Usertsuff ul li #4939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarleaM
Copy link

@MarleaM MarleaM commented Oct 10, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/jira/software/c/projects/AO3/issues/AO3-5951?filter=allopenissues&jql=project%20%3D%20%22AO3%22%20AND%20statusCategory%20IN%20%28%22To%20Do%22%2C%20%22In%20Progress%22%29%20ORDER%20BY%20updated%20DESC

Purpose

This PR ensures that unordered lists in work summaries or bookmark notes appear with items listed horizontally in blurbs. With this change, they now stack vertically, each with a black circle in front of them, like they display in the summary on the work itself.

Testing Instructions

Log in

Post > New Work

Fill in required fields and, in the "Summary" field, include an unordered list, e.g.

  • list
  • item

Press "Post Without Preview" to post the work

Browse > Bookmarks

Press "Save" on one

In the "Notes" field, include an unordered list using the same HTML from step 3

Press "Create" to save your bookmark

Hi, username! > My Dashboard

The items in your work summary and bookmark notes should appear as normally now, instead of being side by side.

References

n/a

Credit

MarleaM She/Her

Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, MarleaM!

Thank you so much for this pull request -- it looks good to me, so I've marked it Approved and Ready to Merge! However, we're currently in a code freeze until mid-November, so it will be at least a few weeks before it can be merged, tested, and hopefully deployed to production.

In the meantime, I've assigned the Jira issue to you and set its status to In Review, so no one will mistakenly create a duplicate pull request. I've also given your account permission to comment on, assign, and transition issues in the future.

Thanks again for contributing! If you have any questions, you can contact us at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants