Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6796 - fix QA returns for 500 error on fandom_id #4918

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

AliceLoeser
Copy link
Contributor

@AliceLoeser AliceLoeser commented Sep 17, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6796

Purpose

This PR is a follow up of this previously merged PR, after QA analysis: #4898

The scenario this PR fixes is the following:

Tried one more test, where I completely deleted all numbers from the fandom_id (https://test.archiveofourown.org/users/testy/works?fandom_id=), which resulted in an Error 500!

Now, fandom_id will be ignored if null.

Testing Instructions

Look at the test scenarios described in this issue: https://otwarchive.atlassian.net/browse/AO3-6796
And test again for "Tried one more test, where I completely deleted all numbers from the fandom_id". Expected behavior is "the behaviour should be to show the /works page as if the fandom_id wasn’t specified."

References

This PR is a follow-up of: #4898

Credit

AliceLsr (feminine pronouns)

Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brianjaustin brianjaustin merged commit 43557ff into otwcode:master Sep 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants