AO3-6796 - fix QA returns for 500 error on fandom_id #4918
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6796
Purpose
This PR is a follow up of this previously merged PR, after QA analysis: #4898
The scenario this PR fixes is the following:
Now,
fandom_id
will be ignored if null.Testing Instructions
Look at the test scenarios described in this issue: https://otwarchive.atlassian.net/browse/AO3-6796
And test again for "Tried one more test, where I completely deleted all numbers from the fandom_id". Expected behavior is "the behaviour should be to show the /works page as if the fandom_id wasn’t specified."
References
This PR is a follow-up of: #4898
Credit
AliceLsr (feminine pronouns)