Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO3-6467 Record Fannish Next of Kin changes in user history #4582

Merged
merged 32 commits into from
Aug 28, 2023
Merged

AO3-6467 Record Fannish Next of Kin changes in user history #4582

merged 32 commits into from
Aug 28, 2023

Conversation

ceithir
Copy link
Contributor

@ceithir ceithir commented Jul 18, 2023 •
edited
Loading

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6467

Purpose

Track and display changes to FNOK in admin, on both sides of the relationship

Testing Instructions

See JIRA

References

Alterity should supposedly take care of all the pt-online-schema-change automagically.
Obsolete, see #4582 (comment)

Credit

Ceithir (he/him)

@github-actions github-actions bot added Has Migrations Contains migrations and therefore needs special attention when deploying Gem Updates Awaiting Review labels Jul 18, 2023
ceithir
ceithir commented Jul 18, 2023
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
ceithir
ceithir commented Jul 18, 2023
View reviewed changes
config/i18n-tasks.yml Outdated Show resolved Hide resolved
sarken
sarken requested changes Aug 21, 2023
View reviewed changes
app/helpers/users_helper.rb Outdated Show resolved Hide resolved
features/admins/users/admin_fnok.feature Outdated Show resolved Hide resolved
ceithir
ceithir commented Aug 21, 2023
View reviewed changes
app/helpers/users_helper.rb Outdated Show resolved Hide resolved
spec/controllers/users_controller_spec.rb Show resolved Hide resolved
sarken
sarken requested changes Aug 24, 2023
View reviewed changes
app/helpers/users_helper.rb Outdated Show resolved Hide resolved
app/helpers/users_helper.rb Outdated Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
spec/controllers/users_controller_spec.rb Show resolved Hide resolved
spec/models/user_spec.rb Outdated Show resolved Hide resolved
app/helpers/users_helper.rb Show resolved Hide resolved
@sarken sarken changed the title AO3 6467 Record Fannish Next of Kin changes in user history AO3-6467 Record Fannish Next of Kin changes in user history Aug 24, 2023
sarken
sarken approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sarken sarken merged commit 49581cc into otwcode:master Aug 28, 2023
24 checks passed
@sarken sarken added this to the 0.9.351 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarken sarken sarken approved these changes

Assignees
No one assigned
Labels
Has Migrations Contains migrations and therefore needs special attention when deploying Priority: High Reviewed: Ready to Merge
Projects
None yet
Milestone
0.9.351
Development

Successfully merging this pull request may close these issues.
4 participants
@ceithir @sarken @zz9pzza @brianjaustin