AO3-6541 Update Works search and filters to use "Creator" instead of "Author/Artist"

[forceofcalm]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

This PR is for AO3-6541, which requested an update of the terminology used on the search forms. This update switches "Author/Artist" to "Creator".

Purpose

This PR updates instances of "Author/Artist" to "Creator" on the work search forms.

Credit

calm, they/them

[forceofcalm]

Wondering if I should actually do this, since we have instances of whitespace in "Date Posted", "Date Updated", etc. so it wouldn't be consistent on each? I'm a Ruby noob, welcome to other thoughts here.

[hound]

Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.

[weeklies]

I believe the issue is asking only for a frontend change. If you undo the backend changes made and keep the visual edits, this should make the tests pass.

[brianjaustin]

Hi @forceofcalm, what @weeklies said is correct

I believe the issue is asking only for a frontend change.

We'd prefer to keep the changes small to avoid unintended consequences (like potentially breaking searches people have bookmarked). There's precedent for this with history (previously named readings) or username/login/user name (all of which are used in various places)