AO3-2722 Hound fix

otwcode · Jun 24, 2023 · 9608135 · 9608135
1 parent a123664
commit 9608135
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/app/models/skin_parent.rb b/app/models/skin_parent.rb
@@ -10,9 +10,9 @@ class SkinParent < ApplicationRecord
 
   validate :no_site_parent
   def no_site_parent
-    if parent_skin&.get_role == "site" && !%w(override site).include?(child_skin.get_role)
-      errors.add(:base, ts("^You can't use %{title} as a parent unless replacing the default archive skin.", title: parent_skin.title))
-    end
+    return unless parent_skin&.get_role == "site" && !%w[override site].include?(child_skin.get_role)
+
+    errors.add(:base, ts("^You can't use %{title} as a parent unless replacing the default archive skin.", title: parent_skin.title))
   end
 
   validate :no_circular_skin