🌱 Tighten restrictions for running scdiff workflow
#4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we matched GitHub's "Require approval for first-time contributors", which represents a minor barrier for attackers (e.g. submitting a typo fix). Project members should ensure their visibility in the "ossf" GitHub org is "Public" to be able to run scdiff. Signed-off-by: Spencer Schrock <[email protected]>
There is a small window after leaving an scdiff comment, where the workflow queues then sends an API request to determine the PR head SHA. An attacker could use this time to push new code that wasn't reviewed. This change attempts to ensure the code that runs is older than the code the requester saw when leaving the scdiff comment. Both timestamps used are controlled by GitHub, not a user controlled timestamp. There may be some false positives, as `repo.pushed_at` corresponds to all repo activiy, not just the branch used for the PR. This risk is acceptable as it's better to be safe; we can always re-run the workflow. Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
naveensrinivasan
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
workflow change
What is the current behavior?
Any previous contributor can run the
scdiffworkflowWhat is the new behavior (if this is a feature change)?**
Only members of the
ossfGitHub org can run thescdiffworkflow.Previously we matched GitHub's "Require approval for first-time
contributors", which represents a minor barrier for attackers
(e.g. submitting a typo fix). Project members should ensure their
visibility in the "ossf" GitHub org is "Public" to be able to run
scdiff.
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)