Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScanSummary: Do not use sorted set for licenseFindings #7004

Merged
merged 4 commits into from
May 16, 2023
Merged

ScanSummary: Do not use sorted set for licenseFindings #7004

merged 4 commits into from
May 16, 2023

Commits on May 16, 2023

  1. refactor(ScanSummary): Do not use sorted set for licenseFindings 

    Only sort on serialization for human readability and reproducibility.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ff4a900 View commit details
    Browse the repository at this point in the history

  2. refactor: Return a set from mergeLicenseFindings() 

    Returning a sorted set is no more necessary, because `ScanSummary` has
been changed in a preceeding change to use a set for the copyright
findings.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 16, 2023
    Configuration menu
    Copy the full SHA
    01fbbe6 View commit details
    Browse the repository at this point in the history

  3. fix(AbstractStorageFunTest): Assign an immutable list to issues 

    Using a mutable one is not needed.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 16, 2023
    Configuration menu
    Copy the full SHA
    6b2cc7d View commit details
    Browse the repository at this point in the history

  4. refactor(ScanSummary): Inline two variables 

    Make the code consistent with the function below.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 16, 2023
    Configuration menu
    Copy the full SHA
    0862259 View commit details
    Browse the repository at this point in the history