Statistics / ScannerRun: Do not use sorted data structures #7002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
changed the title
fviernau
force-pushed
the
statistics-no-sorted-ds
branch
from
34aefbe
to
b1e2c7f
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7002 +/- ##
=========================================
Coverage 64.31% 64.31%
Complexity 1970 1970
=========================================
Files 331 331
Lines 16690 16690
Branches 2382 2382
=========================================
Hits 10734 10734
Misses 4919 4919
Partials 1037 1037
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
requested changes
May 16, 2023
fviernau
force-pushed
the
statistics-no-sorted-ds
branch
from
b1e2c7f
to
ed80991
Compare
fviernau
force-pushed
the
statistics-no-sorted-ds
branch
from
ed80991
to
eea838b
Compare
sschuberth
approved these changes
May 16, 2023
|
@fviernau, the second commit needs a conventional type in the title. |
Only sort on serialization for human readability and reproducibility. Signed-off-by: Frank Viernau <[email protected]>
Only sort on serialization for human readability and reproducibility. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
statistics-no-sorted-ds
branch
from
eea838b
to
5da65e3
Compare
mnonnenmacher
added
the
breaking API change
sschuberth
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of #6235.