ScanSummary: Do not use sorted set for copyrightFindings
#7000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
copyright-findings-set
branch
from
5436ab1
to
f31747d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7000 +/- ##
============================================
- Coverage 64.31% 64.30% -0.01%
Complexity 1970 1970
============================================
Files 331 331
Lines 16690 16692 +2
Branches 2382 2382
============================================
Hits 10734 10734
- Misses 4919 4921 +2
Partials 1037 1037
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
fviernau
changed the title
copyrightFingingscopyrightFindings
sschuberth
requested changes
May 16, 2023
fviernau
force-pushed
the
copyright-findings-set
branch
from
f31747d
to
587a043
Compare
sschuberth
reviewed
May 16, 2023
fviernau
force-pushed
the
copyright-findings-set
branch
from
587a043
to
79701d0
Compare
fviernau
force-pushed
the
copyright-findings-set
branch
from
79701d0
to
0454467
Compare
sschuberth
requested changes
May 16, 2023
This simplifies an upcoming change. Signed-off-by: Frank Viernau <[email protected]>
This simplifies upcoming changes. Signed-off-by: Frank Viernau <[email protected]>
This simplifies an upcoming change. Signed-off-by: Frank Viernau <[email protected]>
Only sort on serialization for human readability and reproducibility. While that allows to remove the implementation of the comparable interface, still keep the comparator constant for use in the converter and any place where `CopyrightFinding`s shall be shown to users. Signed-off-by: Frank Viernau <[email protected]>
Returning a sorted set is no more necessary, because `ScanSummary` has been changed in a preceeding change to use a set for the copyright findings. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
copyright-findings-set
branch
from
0454467
to
b790ed2
Compare
sschuberth
approved these changes
May 16, 2023
mnonnenmacher
added
the
breaking API change
sschuberth
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of #6235, also needed by #6945.