Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cometbft/cosmos-sdk versions #8779

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

crnbarr93
Copy link
Contributor

What is the purpose of the change

Bumping cometbft and cosmos sdk to the lastest versions:

comet => https://github.com/osmosis-labs/cometbft/releases/tag/v0.38.12-v27-osmo-1
cosmossdk => https://github.com/osmosis-labs/cosmos-sdk/releases/tag/v0.50.10-v27-osmo-1

@crnbarr93 crnbarr93 added the V:state/breaking State machine breaking PR label Oct 18, 2024
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

Copy link
Contributor

coderabbitai bot commented Oct 18, 2024

Walkthrough

The CHANGELOG.md file has been updated to include new entries in the "Unreleased" section, detailing state-breaking changes, configuration updates, and state-compatible improvements. Key entries include a version bump for cometbft/cosmos-sdk and various bug fixes and enhancements. The document also summarizes changes from previous versions, ensuring a clear record of significant updates and fixes, organized chronologically with appropriate references.

Changes

File Change Summary
CHANGELOG.md - Added new entries under "Unreleased":
* Bump cometbft/cosmos-sdk versions (#8779)
* Add missing proto files for indexing (#8754)
* Fix multiple temp directories on command executions (#8726)
* Fix unsupported sign-mode issue (#8728)
* Fix concurrency issue in tests (#8765, #8768)
- Updated previous versions sections (v26.0.1, v26.0.0, v25.2.1) with significant changes and fixes.

Possibly related PRs

Suggested labels

C:x/epochs, V:state/compatible/backport

Suggested reviewers

  • mattverse
  • nicolaslara
  • czarcas7ic
  • PaddyMc

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 56ddf9d and 1faf6f6.

⛔ Files ignored due to path filters (6)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
  • osmomath/go.mod is excluded by !**/*.mod
  • osmomath/go.sum is excluded by !**/*.sum, !**/*.sum
  • osmoutils/go.mod is excluded by !**/*.mod
  • osmoutils/go.sum is excluded by !**/*.sum, !**/*.sum
📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🧰 Additional context used
🔇 Additional comments (8)
CHANGELOG.md (8)

50-51: New modules and features added

The v19.0.0 release introduces several significant new modules and features, including SuperCharged Liquidity, CosmWasm Pool Module, and ProtoRev changes. These additions aim to enhance capital efficiency and introduce custom liquidity pools.


Line range hint 53-54: Important security update

The upgrade of wasmvm to 1.2.3 addresses a security vulnerability (CWA-2023-002). This is a critical update that should be highlighted to all users and node operators.


Line range hint 56-65: New features added

The release includes several new features such as the implementation of x/concentrated-liquidity and x/cosmwasmpool modules, new swap types, and ProtoRev changes. These additions significantly expand the functionality of the Osmosis platform.


Line range hint 93-96: Dependencies

The release updates several important dependencies, including wasmd, cosmos SDK, and IBC-go. These updates may introduce new features or fix issues in the underlying libraries.


Line range hint 98-116: Misc Improvements

The release includes various miscellaneous improvements and bug fixes. These changes enhance the overall functionality and stability of the Osmosis platform.


Line range hint 67-77: API breaks

There are numerous API breaks in this release, including changes to queries, pagination, and the removal of some functionalities. These changes may require updates to applications interacting with Osmosis.

It's important to ensure that all API changes are well-documented and that migration guides are provided for users. Let's verify if there's a migration guide available:

#!/bin/bash
# Check for migration guide in docs or root directory
find . -name "*migration*guide*.md" -type f

Line range hint 50-116: Overall assessment of v19.0.0 changes

The v19.0.0 release of Osmosis introduces significant new features, API changes, and improvements. While the changes appear to enhance the platform's capabilities, there are several points that require careful attention:

  1. The introduction of new modules and features may require updates to existing applications and tools interacting with Osmosis.
  2. The API breaks and state-breaking changes necessitate a well-planned upgrade process and clear communication with all stakeholders.
  3. The security update to wasmvm is critical and should be emphasized in the upgrade instructions.
  4. It's important to ensure that comprehensive testing has been performed, especially for the new features and changes to existing functionalities.

To ensure a smooth upgrade process, let's verify if there are upgrade instructions for node operators:

#!/bin/bash
# Search for upgrade instructions in the repository
find . -name "*upgrade*guide*.md" -type f

This release appears to be a major milestone for Osmosis, but it's crucial to manage the upgrade process carefully to minimize disruptions to the network and its users.


Line range hint 79-91: State Breaking changes

The release includes several state-breaking changes, such as adding ICA authorized messages, fixing TWAP record upgrade handlers, and implementing gas consumption on denom creation. These changes will require careful consideration during the upgrade process.

We should verify if there's an upgrade handler to manage these state-breaking changes:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@PaddyMc PaddyMc closed this Oct 21, 2024
@PaddyMc PaddyMc reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/epochs V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants