Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWMS ID 11507: Added missing index file #714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aiijazfatima
Copy link

Add here your WMS ID

General requirements

  1. Information in the workshop is adequate and updated
  2. Code is correct and working
  3. Links are correct
  4. Make sure you enter the help email link in your manifest.json
  5. Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list

Please confirm that the following is completed before submitting your PR

  • All filenames are lower case (including folders, images, files, etc.)
  • Filenames are descriptive
  • Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
  • Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
  • Image references in markdown contain an alternate text

@aiijazfatima
Copy link
Author

Please deploy this as soon as possible. Users are not able to access this site.

Copy link
Contributor

@carmenberdant1 carmenberdant1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aiijazfatima the bitly link in this index.html file is outdated. Please use the index.html from the common file. I'll dm you the path.

@carmenberdant1
Copy link
Contributor

@aiijazfatima this branch is out-of-date please merge it with the latest changes

Copy link
Contributor

@anacoman11 anacoman11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aiijazfatima, please add the right WMS ID in the title of the PR, resolve the branch out-of-date issue and replace the https://bit.ly/golivelabs URL with https://livelabs.oracle.com

Copy link
Contributor

@klazarz klazarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aiijazfatima please change href in Oracle LiveLabs anchor to livelabs.oracle.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants