Lixdk 194 default content addressable id for snapshots #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able-id-for-snapshots # Conflicts: # lix/packages/sdk/src/file-handlers.ts # lix/packages/sdk/src/open/openLix.ts
|
| id: "sn3", | ||
| value: { id: "mock-id", color: "green" }, | ||
| }, | ||
| createPhantomSnapshot({ id: "mock-id", color: "red" }), |
There was a problem hiding this comment.
Why phantom snapshot?
- unclear what phantom is referring to
- unclear that it's a JSON snapshot (and not a blob)
Suggested change
| createPhantomSnapshot({ id: "mock-id", color: "red" }), | |
| createJsonSnapshot({ id: "mock-id", color: "red" }), |
| return; | ||
| } | ||
| runNumber++; | ||
| // try { |
There was a problem hiding this comment.
Why was the try removed?
Comment on lines
+138
to
+142
| // console.error( | ||
| // "change queue failed (will remain so until rework of change queue): ", | ||
| // e, | ||
| // ); | ||
| // } |
There was a problem hiding this comment.
Why was the console.error removed?
| * @returns | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| export const createPhantomSnapshot = function (content: Record<string, any>) { |
There was a problem hiding this comment.
Suggested change
| export const createPhantomSnapshot = function (content: Record<string, any>) { | |
| export const createJsonSnapshot = (content: Record<string, any>) => { |
samuelstroschein
approved these changes
Oct 18, 2024
samuelstroschein
deleted the
lixdk-194-default-content-addressable-id-for-snapshots
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.