-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lixdk 194 default content addressable id for snapshots #3181
Lixdk 194 default content addressable id for snapshots #3181
Conversation
…able-id-for-snapshots # Conflicts: # lix/packages/sdk/src/file-handlers.ts # lix/packages/sdk/src/open/openLix.ts
|
id: "sn3", | ||
value: { id: "mock-id", color: "green" }, | ||
}, | ||
createPhantomSnapshot({ id: "mock-id", color: "red" }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why phantom snapshot?
- unclear what phantom is referring to
- unclear that it's a JSON snapshot (and not a blob)
createPhantomSnapshot({ id: "mock-id", color: "red" }), | |
createJsonSnapshot({ id: "mock-id", color: "red" }), |
return; | ||
} | ||
runNumber++; | ||
// try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the try removed?
// console.error( | ||
// "change queue failed (will remain so until rework of change queue): ", | ||
// e, | ||
// ); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the console.error removed?
* @returns | ||
*/ | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
export const createPhantomSnapshot = function (content: Record<string, any>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const createPhantomSnapshot = function (content: Record<string, any>) { | |
export const createJsonSnapshot = (content: Record<string, any>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mockJsonSnapshot
is a good choice
No description provided.