-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserCard: do not show "Create copy" button if user not allowed to publish the card (#7427) #7440
base: develop
Are you sure you want to change the base?
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces significant modifications to both the Cypress integration tests for the User Card functionality and the Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🔇 Additional comments (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
private doesTheUserHavePermissionToPublishCard(): boolean { | ||
if (!this.cardState.userCard.publisherList) return true; | ||
const userEntities = UserService.getCurrentUserWithPerimeters().userData.entities; | ||
const allowedPublishers = EntitiesService.resolveEntities(this.cardState.userCard.publisherList); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suggest to name the method isUserMemberOfAnEntityAllowedToPublishForThisState()
This is to be more precise and avoid confusion with the other control : UserService.isWriteRightsForProcessAndState
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
…lish the card (#7427) Signed-off-by: Giovanni Ferrari <[email protected]>
25bfa7b
to
f7348a6
Compare
Quality Gate passedIssues Measures |
Fix #7427