ci: moves ActiveMQ and RabbitMQ to new docker images #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| collector = builder().storage(buildStorage(consumer)).build().start(); | ||
|
|
||
| pushMessage(collector.queue, PROTO3.encodeList(spans)); |
There was a problem hiding this comment.
moved this as I needed a non stopped collector instance. It doesn't change the nature of the test
|
oops forgot to click to make them public |
Notably, this removes a JUnit 4 dependency in activemq and should fix flakes related to ActiveMQ integration tests. Fixes #3633 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
new-docker
branch
from
eb28fd4
to
2c0dae1
Compare
|
rebased |
|
kicked the JDK 11 build. I'm not sure what it hung on, but it spent 10 minutes with no feedback in the zipkin-server module. This isn't a repeating flake pattern so far.. |
anuraaga
approved these changes
Dec 13, 2023
|
thanks for the support for the last week plus @anuraaga! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably, this removes a JUnit 4 dependency in activemq and should fix flakes related to ActiveMQ integration tests.
Fixes #3633
After this, I will rebase #3635 and hopefully it doesn't flake anymore. If so, I'll merge that and cut the pending minor.