refactor: migrates from JUnit 4 to JUnit 5 (Jupiter) #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates from JUnit 4 to JUnit 5 (Jupiter) beginning with the following OpenRewrite command:
After this, we had to do some work, notably as Brave needs to support non-alpha versions of OkHttp and alpha 5 creates a classpath conflict on Okio. Notably, I had to revert changes for the okhttp and urlconnection senders, which formerly used normal mockwebserver 3 and were automatically migrated to v5 alpha.
Next, I had to polish formatting as it undid some of that, and also fixed some cases where we were inconsistent. Then, I reviewed our base pom and removed some special cases that were no longer needed. Finally, I swept through and reduced visibility modifiers where possible.
Note: Both testcontainers and mockwebserver v3 have an implicit dep on junit 4. This is ok and the same as zipkin. The main thing here is we aren't explicitly using it anymore.