Stops publishing kafka08 sender #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
depends on #216 which increments the minor version |
This stops publishing the kafka08 sender, beginning at the next minor version, 2.17. This has been unsupported by Kafka since 2015 and corresponding configuration removed in Zipkin in mid 2019. Removing this removes tech debt around the similarly abandoned junit rule used to test it. See openzipkin/zipkin#2564 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
kafka-axe
branch
from
770a418
to
c57f37c
Compare
|
rebased. p.s. In the miniscule chance this is still needed someone can raise an issue to restore it, though this never happened for zipkin's repo where it was removed. |
anuraaga
approved these changes
Dec 12, 2023
|
thanks for the looks @anuraaga! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops publishing the kafka08 sender, beginning at the next minor version, 2.17. This has been unsupported by Kafka since 2015 and corresponding configuration removed in Zipkin in mid 2019. Removing this removes tech debt around the similarly abandoned junit rule used to test it.
See openzipkin/zipkin#2564