-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes traceIdHigh convertable to AWS X-Ray #509
Conversation
89f93f4
to
5c90955
Compare
benchmarks suggest using a time component causes the high bits to generate an order of magnitude slower than a thread local random (present in JRE7). IMHO, this is ok, as it only affects the root trace ID when that trace is generated locally (vs ingress). For example, the low bits of the trace ID and each span ID have the same generation time as before.
|
f5aa7c2
to
d415149
Compare
note: this impl uses longs because Brave 4 still stores 128-bit trace IDs as two uint64s. If this weren't the case, I would be generating a string instead. |
Added end-to-end benchmarks. This change is not statistically significant vs even 64bit trace ID
|
3f404e5
to
645bfbf
Compare
This customizes the trace ID generator to make the high bits convertable to Amazon X-Ray trace ID format v1.
645bfbf
to
46ef389
Compare
This customizes the trace ID generator to make the high bits convertable
to Amazon X-Ray trace ID format v1.
See openzipkin/zipkin#1754