hotplug: allow button timeout actions to trigger a subsequent timeout #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows visual feedback when timeouts are reached. In our case, there is a single button which on a normal press/release will initiate DPP, but longer presses will first reboot then factory reset. So users know they've held it down long enough, it's nice to change the state of an LED. This also fixes what seems to me a bug, in that you can attach a timeout to a 'release' action but the timing was reset (so you can't distinguish between a released timeout vs a pressed timeout).
wryun
force-pushed
the
hotplug-button-timeouts-can-trigger-timeout
branch
from
4fb9bc5
to
7e338e2
Compare
morse-arienjudge
pushed a commit
to MorseMicro/openwrt
that referenced
this pull request
Sep 19, 2024
This allows visual feedback when timeouts are reached. In our case, there is a single button which on a normal press/release will initiate DPP, but longer presses will first reboot then factory reset. So users know they've held it down long enough, it's nice to change a status LED. This also fixes what seems to me a bug, in that you can attach a timeout to a 'release' action but the timing was reset (so you can't distinguish between a released timeout vs a pressed timeout). See: openwrt/procd#10 Approved-by: Sophronia Koilpillai Approved-by: Arien Judge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows visual feedback when timeouts are reached.
In our case, there is a single button which on a normal press/release will initiate DPP, but longer presses will first reboot then factory reset. So users know they've held it down long enough, it's nice to change a status LED.
This also fixes what seems to me a bug, in that you can attach a timeout to a 'release' action but the timing was reset (so you can't distinguish between a released timeout vs a pressed timeout).